Remove secrets encryption controller #10612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
brandond
requested changes
Jul 30, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10612 +/- ##
==========================================
- Coverage 49.52% 43.68% -5.84%
==========================================
Files 179 178 -1
Lines 14955 14890 -65
==========================================
- Hits 7406 6505 -901
- Misses 6193 7189 +996
+ Partials 1356 1196 -160
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Derek Nola <derek.nola@suse.com>
brandond
previously approved these changes
Jul 31, 2024
brandond
reviewed
Jul 31, 2024
Signed-off-by: Derek Nola <derek.nola@suse.com>
vitorsavian
previously approved these changes
Aug 7, 2024
brandond
requested changes
Aug 12, 2024
Signed-off-by: Derek Nola <derek.nola@suse.com>
brandond
approved these changes
Aug 22, 2024
vitorsavian
approved these changes
Aug 22, 2024
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Sep 3, 2024
* Remove secrets encryption controller Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Sep 3, 2024
* Remove secrets encryption controller Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Sep 3, 2024
* Remove secrets encryption controller Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
that referenced
this pull request
Sep 4, 2024
* Remove secrets encryption controller Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
that referenced
this pull request
Sep 4, 2024
* Remove secrets encryption controller Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Sep 6, 2024
* Remove secrets encryption controller Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
that referenced
this pull request
Sep 6, 2024
* Remove secrets encryption controller Signed-off-by: Derek Nola <derek.nola@suse.com>
ludost
pushed a commit
to asimovo-platform/k3s
that referenced
this pull request
Oct 2, 2024
* Remove secrets encryption controller Signed-off-by: Derek Nola <derek.nola@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Types of Changes
Code simplification
Verification
CI still green
Testing
This is covered by existing E2E and integration tests
Linked Issues
#10581
User-Facing Change
Further Comments